graphicName SVG rendering issues in some Safari and Chrome versions

[ahocevar]

Related webkit bug:  https://bugs.webkit.org/show_bug.cgi?id=33322

A workaround is to not use defs/use with the webkit versions in question. The attached patch introduces a workaround.

Please review.

[ahocevar]

new patch fixing the target.parentNode issue reported by crschmidt

[ahocevar]

(In [9937]) workaround for webkit versions that have problems with defs/use. r=crschmidt (closes #2402)

[fredj]

(In [9946]) fix tests for buggy webkit. (see #2402)

[ahocevar]

fixed rotation issue

[ahocevar]

It turned out that not all WebKit versions that cannot use defs can rotate svg elements. The attached patch also fixes this issue, and rotation is now back for all WebKit versions.

Tests still pass, please review.

[tschaub]

Code looks good. I'm trusting that the example works in the target browser (don't have it right now).

One minor suggestion: I don't think we should use things like OpenLayers.String.format internally unless we absolutely need to. You could argue that it improves readability, but in particularly hot areas of the library, I think it makes sense to pick performance first. While the own time of that chunk of code is low compared to the rendering time of a single node, concatenation is about 10 times faster than OpenLayers.String.format.

var style = {
    rotation: 45
};
var pos = {
    x: 2, y: 3
};

var i, str, len = 10000;

var loopStart = new Date();
for (i=0; i<len; ++i) {}
var loopElapsed = new Date() - loopStart;

var formatStart = new Date();
for (i=0; i<len; ++i) {
    str = OpenLayers.String.format(
        "rotate(${0} ${1} ${2})",
        [style.rotation, pos.x, pos.y]
    );
}
var formatElapsed = new Date() - formatStart - loopElapsed;

var concatStart = new Date();

for (i=0; i<len; ++i) {
    str = "rotate(" + style.rotation + " " + pos.x + " " + pos.y + ")";
}
var concatElapsed = new Date() - concatStart - loopElapsed;


console.log(formatElapsed / len, concatElapsed / len);

Anyway, thanks for all the bug hunting on this.

[ahocevar]

(In [9953]) fixed rotation for browsers that don't support defs/use. Committed version modified from patch version as suggested by tschaub. r=tschaub (closes #2402)