Ticket #2383 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

overview map control destroys drag handler too late

Reported by: elemoine Owned by:
Priority: major Milestone: 2.9 Release
Component: Control.OverviewMap Version: 2.8
Keywords: Cc:
State: Complete

Description

the overview map control destroys its drag handler after it destroys its OpenLayers.Map object (ovmap), this causes dereferencing null (map.events) when it the handler's destroy method deactivates the handler. Patch to come.

Attachments

patch-2383-r9898-A0.diff Download (2.7 KB) - added by elemoine 3 years ago.

Change History

Changed 3 years ago by elemoine

Changed 3 years ago by elemoine

  • owner elemoine deleted
  • state set to Review

patch-2383-r9898-A0.diff Download fixes it, tests pass in FF3.6b4.

Changed 3 years ago by ahocevar

  • state changed from Review to Commit

These destroy issues are always more interesting to test in IE. So if you can confirm that tests also pass in IE, and that unloading the overviewmap.html example page does not cause an error in IE, you can commit.

Changed 3 years ago by elemoine

Tests pass in FF3.6b4, IE8, Chromium. The overviewmap.html example works as expected, an unloading the page does not cause error in any of the aforementioned browser.

Changed 3 years ago by elemoine

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9902]) overview map control destroys drag handler too late, r=ahocevar (closes #2383)

Note: See TracTickets for help on using tickets.