Layer.WFS missing OpenLayers.Util.upperCaseObject(params)

[pdziemiela]

Hi folks,

I was messing about with geoserver 2.0 and WFS version 1.1.0 and noticed that OpenLayers does not respect the version parameter in the initialize function.

If I pass in parameter "version: '1.1.0'", I get back

?typename=topp%3Arad_305b_l_pg &version=1.1.0 &SERVICE=WFS &VERSION=1.0.0 &REQUEST=GetFeature &SRS=EPSG%3A4326 &BBOX=-87.97359617915488,42.52413820958627,-87.72640379638788,42.6757695301923

In comparing things to the WMS, it looks like we are missing:

//uppercase params params = OpenLayers.Util.upperCaseObject(params);

at the top of initialize around line 122 in /Layer/WFS.js

Patch is attached.

Cheers,

Paul

[pdziemiela]

patch

[bartvde]

Hi, not sure if Layer.WFS will still be maintained, you should be using an OpenLayers.Layer.Vector with a Protocol.WFS and a Strategy (BBOX e.g.) instead. Check examples\wfs-protocol.html.

[elemoine]

Replying to bartvde:

Hi, not sure if Layer.WFS will still be maintained, you should be using an OpenLayers.Layer.Vector with a Protocol.WFS and a Strategy (BBOX e.g.) instead. Check examples\wfs-protocol.html.

yet, applying this patch would make sense to me, as it's trivial and harmless. What do you think?

[bartvde]

Hi Eric, true, feel free to commit this one. I did not check if it breaks any tests though where params are maybe lowercase.

[pdziemiela]

Hi Bart,

Your comments make sense however I am not sure where I would have picked up the idea that Layer.WFS is deprecated. When searching the dev examples for "WFS", I get 10 results. Four of the results use Layer.Vector but six of the results use Layer.WFS. As I was just trying to slap something together quick I guess I gravitated to the Layer.WFS interface as being simpler. Is there a need to add some comments to the Layer.WFS code to direct people towards using Layer.Vector? Secondly, should there be a task to rewrite those six examples to bypass the Layer.WFS interface?

Cheers, Paul

[bartvde]

Thanks for the feedback Paul, we need to do something about this in the examples and the code for sure.

[bartvde]

Deprecated comments added to the source code in r9849

[tschaub]

Replying to pdziemiela:

Hi Bart, Your comments make sense however I am not sure where I would have picked up the idea that Layer.WFS is deprecated. When searching the dev examples for "WFS", I get 10 results. Four of the results use Layer.Vector but six of the results use Layer.WFS. As I was just trying to slap something together quick I guess I gravitated to the Layer.WFS interface as being simpler. Is there a need to add some comments to the Layer.WFS code to direct people towards using Layer.Vector? Secondly, should there be a task to rewrite those six examples to bypass the Layer.WFS interface? Cheers, Paul

See r9861, r9862, r9863, r9864, and r9865.

When the examples are re-parsed, this will be more relevant: http://openlayers.org/dev/examples/?q=wfs

[bartvde]

(In [10109]) Layer.WFS missing OpenLayers.Util.upperCaseObject(params), p=pdziemiela, r=elemoine,me (closes #2362)

[bartvde]

pdziemiela, do we have a CLA from you? See:  http://trac.openlayers.org/wiki/HowToContribute TIA.