Ticket #2346 (new task)

Opened 4 years ago

Last modified 3 years ago

have more consistent naming conventions for events

Reported by: bartvde Owned by: euzuro
Priority: minor Milestone: 3.0 Release
Component: Events Version: 2.8
Keywords: Cc:
State:

Description

Currently we use "pre" as well as "before" prefixes, e.g. preaddlayer in Map.js and beforegetfeatureinfo in WMSGetFeatureInfo.js etc.

We should standardize this in 3.0.

Change History

follow-up: ↓ 2   Changed 3 years ago by adube

Here's the list of candidate changes :

OpenLayers/Map.js :

  • addlayer -> layeradded
  • preaddlayer -> beforelayeradded
  • removelayer -> layerremoved
  • changelayer -> layerchanged
  • changebaselayer -> baselayerchanged

OpenLayers/Control/SLDSelect.js :

  • selected -> filtersselected

Requesting comments, please.

in reply to: ↑ 1   Changed 3 years ago by erilem

Replying to adube:

Here's the list of candidate changes : OpenLayers/Map.js : * addlayer -> layeradded * preaddlayer -> beforelayeradded * removelayer -> layerremoved * changelayer -> layerchanged * changebaselayer -> baselayerchanged OpenLayers/Control/SLDSelect.js : * selected -> filtersselected Requesting comments, please.

I'd personally prefer names like addlayer, preaddlayer, etc, because they're usually shorter.

follow-up: ↓ 4   Changed 3 years ago by bartvde

Hmm, I am actually in favour of "before" instead of "pre", since this seems to be more common (Microsoft specific events such as beforecut, Ext JS events). Are there other libraries using "pre"?

in reply to: ↑ 3   Changed 3 years ago by erilem

Replying to bartvde:

Hmm, I am actually in favour of "before" instead of "pre", since this seems to be more common (Microsoft specific events such as beforecut, Ext JS events). Are there other libraries using "pre"?

I was just trying to save a few bits, but "before" would work for me as well.

Note: See TracTickets for help on using tickets.