add setLayer function to SelectFeature control

[bartvde]

To be able to tie a layer dynamically to the select feature control.

[bartvde]

patch without tests

[bartvde]

I would appreciate it if someone more knowledgeable than me on the SelectFeature control could look at my approach, before I add tests. TIA.

[ahocevar]

Hey Bart, thanks for your efforts on this. The patch does the right thing, but IMO you could separate the code that is common with the initialize method out to a separate method:

        if(layers instanceof Array) {
            this.layers = layers;
            this.layer = new OpenLayers.Layer.Vector.RootContainer(
                this.id + "_container", {
                    layers: layers
                }
            );
        } else {
            this.layer = layers;
        }

[bartvde]

Thanks Andreas, I'll do that and I will add some tests as well.

[bartvde]

new patch incorporating ahocevar's comments and includes tests now

[ahocevar]

This looks good. Please commit if you can confirm that tests pass.

[bartvde]

(In [9789]) add setLayer function to SelectFeature control so that we can change the layer attached to the control on the fly, r=ahocevar (closes #2340)

[crschmidt]

Oh hey, I had no idea this existed. Nice job. :)

[bjornharrtell]

Me neither so got bartvde to mark it as API :)