move pink tiles to css

[tschaub]

When image loading fails, we should set a css class on the image instead of setting the background style color.

In OpenLayers.Util.onImageLoadError, if OpenLayers.Util.onImageLoadErrorColor is null, we could add an olImageLoadError class. Then we could set OpenLayers.Util.onImageLoadErrorColor to null and create a style declaration with pink to maintain backwards compatibility.

[rdewit]

Works in FF3.5, IE6/8. Please review.

[rdewit]

Now with tests and updated examples.Relevant tests pass in FF3.5

[rdewit]

Goes into theme/default/img/

[ahocevar]

(In [9758]) making pink tiles a css matter. p=rdewit, r=me (closes #2318)

[rdewit]

The changed behaviour with regards to the src url of the image introduces a 'usability' regression: it's not easy any more to see the error behind a broken image (by right-clicking on it and viewing the image).

[rdewit]

This patch needs to be applied to trunk (so don't revert the old one please).

[rdewit]

Patch 2318-2 reverts the setting of the src URL of the broken image. If you want to completely hide a broken image, just use the following CSS in your project:

    <style type="text/css">
        .olImageLoadError {
            opacity: 0 !important;
            filter: alpha(opacity=0) !important;
        }
    </style>

If you only want to get rid of the pink in the tiles whilst still showing that the images are broken, you can do the following:

    <style type="text/css">
        .olImageLoadError {
            border-color: transparent !important;
        }
    </style>

You only need the !important bit if you set your CSS before the OL css gets loaded.

Please review. If all is well, please remove the image that has been added with patch 2318-1 (theme/default/broken.png) from trunk.

Thanks, Roald

[rdewit]

Oops, that last block of code should have been:

    <style type="text/css">
        .olImageLoadError {
            background-color: transparent !important;
        }
    </style>

Relevant tests pass and the solution works in FF3.5, Chromium 4, IE6/8 & Opera 10.

[elemoine]

2318-2.broken-images.patch looks good to me. I tested it in FF3, Safari3, IE8 and IE6. I also ran the tests in these browsers. (Tests don't pass in several places! But the failures aren't related to this particular patch). Thanks for the work rdewit.

[elemoine]

(In [9771]) do not change the src of broken images, as this prevents from being able to right-click on the image and see the server error, p=rdewit, r=me (closes #2318)

[rdewit]

Hi elemoine, thank you for committing the patch. Could you please also remove the file theme/default/img/broken.png since it is not needed anymore? Thanks, rdewit

[ahocevar]

r9773