Ticket #2286 (closed feature: fixed)

Opened 4 years ago

Last modified 4 years ago

Option to turn off animation of Layer.VirtualEarth

Reported by: ahocevar Owned by: euzuro
Priority: minor Milestone: 2.9 Release
Component: Layer.VirtualEarth Version: 2.8
Keywords: Cc:
State: Complete

Description

The VirtualEarth layer has a zoom animation which does not match the zooming experience of other layer types. The attached patch adds an option to turn this animation off.

Attachments

openlayers-2286.patch Download (1.0 KB) - added by ahocevar 4 years ago.

Change History

Changed 4 years ago by ahocevar

Changed 4 years ago by crschmidt

oh, yay, they finally added an option to turn this off.

(I last looked in v3, so this may not be recent ;))

Shoudl we maybe default to 'off' (even thought that's a behavior change) since the current behavior is buggy?

Changed 4 years ago by ahocevar

I have no strong opinion on either, but it may be possible that there are people use VE in OL because it is animated.

Changed 4 years ago by tschaub

  • state changed from Review to Commit

Looks good. Thanks for the find. Please commit.

If we hear on the list that others want this to be true by default, we can change the default. I'm happy either way.

Changed 4 years ago by tschaub

Actually, crschmidt's comment makes me wonder if we should do a quick check for SetAnimationEnabled before calling it. We can't control what version people have loaded, and we might start failing if someone is using a version that doesn't have it. Andreas, how about adding a quick check before calling it?

Changed 4 years ago by crschmidt

Well, we don't work with v3 anymore, right? Or maybe we still do... anyway, v3 doesn't exist, so I'm happy with it going in without a check, though adding it is always polite and may help save us later on down the road.

Changed 4 years ago by ahocevar

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9696]) added option to turn of animation. r=crschmidt,tschaub (closes #2286)

Changed 4 years ago by ahocevar

added with check, as proposed by tschaub.

Note: See TracTickets for help on using tickets.