Ticket #2246 (closed feature: fixed)

Opened 4 years ago

Last modified 2 years ago

wrapDateLine is not supported by XYZ layers

Reported by: tomh Owned by: pgiraud
Priority: minor Milestone: 2.11 Release
Component: Layer.XYZ Version: 2.8
Keywords: Cc: tom@…
State: Commit

Description

Layer.XYZ does not support wrapDateLine and uses out of range tile coordinates beyond the date line.

The attached patch makes it respect wrapDateLine.

I would raise this in the Layer.XYZ component, but it doesn't seem to exist...

Attachments

xyz-wrapdateline.patch Download (2.1 KB) - added by tomh 2 years ago.
Updated patch that includes unit tests
patch-2246-xyz-wrapdateline.patch Download (2.3 KB) - added by pgiraud 2 years ago.
Patches updated against trunk
patch-2246-xyz-wrapdateline.2.patch Download (2.3 KB) - added by pgiraud 2 years ago.
Patches updated against trunk

Change History

Changed 2 years ago by tomh

  • component changed from Layer to Layer.XYZ

Changed 2 years ago by tomh

  • state set to Review

Changed 2 years ago by ahocevar

  • state changed from Review to Needs More Work

Can you please add a unit test?

Changed 2 years ago by tomh

Updated patch that includes unit tests

Changed 2 years ago by tomh

  • state changed from Needs More Work to Review

Unit tests added...

Changed 2 years ago by tomh

  • cc tom@… added

Changed 2 years ago by pgiraud

  • owner changed from euzuro to pgiraud

Changed 2 years ago by pgiraud

Patch updated against current revision. I modified tests because they were displaying an "undefined" message. I also set "wrapDateLine" to true by default for the OSM class.

Tests pass on FF3.6 and Chrome 9. Please review.

Changed 2 years ago by pgiraud

Patches updated against trunk

Changed 2 years ago by pgiraud

Patches updated against trunk

Changed 2 years ago by erilem

  • state changed from Review to Commit

Thanks Pierre and Tom. Please commit.

Changed 2 years ago by erilem

Pierre, before commit could you please set wrapDateLine to false in the mobile-drawing.html example, to prevent issues with drawing across the date line? Thanks.

Changed 2 years ago by tschaub

Though I mistyped the date in the message, here's the record of receiving tomh's ICLA:  http://trac.osgeo.org/openlayers/wiki/CLA?action=diff&version=87

Changed 2 years ago by pgiraud

  • status changed from new to closed
  • resolution set to fixed

(In [11864]) Adding wrapDateLine support for XYZ layers. The OSM layer now wraps the date line by default. p=tomh, r=me (Closes #2246)

Note: See TracTickets for help on using tickets.