Ticket #2218 (closed feature: fixed)

Opened 4 years ago

Last modified 4 years ago

OpenLayers.Request: let us choose whether we want to run callbacks or not (without duplicating code)

Reported by: fvanderbiest Owned by: tschaub
Priority: minor Milestone: 2.9 Release
Component: Request Version: SVN
Keywords: Cc:
State: Review

Description

The following patch moves a portion of the code from the "issue" method to a "runCallbacks" method, which gives application developers the choice to manually execute runCallbacks (eg: when the user accepts to load a heavy response from a server) without duplicating OpenLayers's code.

Tests pass on FF3/linux.

Attachments

openlayers_ticket2218_r9607_A0.diff Download (4.7 KB) - added by fvanderbiest 4 years ago.
openlayers_ticket2218_r9616_A1.diff Download (4.8 KB) - added by elemoine 4 years ago.
openlayers_ticket2218_r9619_A2.diff Download (4.6 KB) - added by fvanderbiest 4 years ago.
runCallbacks now uses the standard requestUrl options key instead of url

Change History

Changed 4 years ago by fvanderbiest

Changed 4 years ago by elemoine

Changed 4 years ago by elemoine

openlayers_ticket2218_r9616_A1.diff Download uses "this" where it makes sense. I'm confirming that the tests pass on FF3, IE8, Safari 4 and Opera 9.24. François, tell me if the patch works for you.

Changed 4 years ago by fvanderbiest

Works great! Thank's Eric. Please commit.

Changed 4 years ago by fvanderbiest

runCallbacks now uses the standard requestUrl options key instead of url

Changed 4 years ago by elemoine

  • status changed from new to closed
  • resolution set to fixed

closed with [9621]

Note: See TracTickets for help on using tickets.