Ticket #2217 (closed feature: fixed)

Opened 4 years ago

Last modified 4 years ago

LineString.js implied global vars

Reported by: igrcic Owned by:
Priority: trivial Milestone: 2.9 Release
Component: Geometry.LineString Version: 2.8
Keywords: Cc:
State: Complete

Description

point1 & point2 var inside getSortedSegments func are implied globs. Declare them inside function.

Attachments

LineString_globs.diff Download (419 bytes) - added by igrcic 4 years ago.

Change History

Changed 4 years ago by igrcic

Changed 4 years ago by elemoine

  • status changed from new to closed
  • state set to Complete
  • resolution set to fixed

(In [9611]) make the point1 and point2 variables local to the getSortedSegments method, no functional change, p=igrcic (closes #2217)

Changed 4 years ago by elemoine

igrcic, do we have a contributor agreement from you?

Changed 4 years ago by elemoine

  • status changed from closed to reopened
  • resolution fixed deleted

reopening, [9611] went to a sandbox as opposed to trunk

Changed 4 years ago by elemoine

  • status changed from reopened to closed
  • resolution set to fixed

(In [9612]) make the point1 and point2 variables local to the getSortedSegments method, no functional change, p=igrcic (closes #2217)

Note: See TracTickets for help on using tickets.