Ticket #2201 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

GetFeatureInfo request needs all required GetMap parameters except VERSION (and REQUEST is GetFeatureInfo of course)

Reported by: tschaub Owned by:
Priority: minor Milestone: 2.9 Release
Component: general Version: 2.8
Keywords: Cc:
State: Complete

Description


Attachments

2201.patch Download (2.3 KB) - added by tschaub 4 years ago.
include "format" parameter in requests
2201.2.patch Download (2.3 KB) - added by elemoine 4 years ago.
ticket2201.patch Download (1.5 KB) - added by bartvde 4 years ago.
alternative patch using layer params.FORMAT

Change History

Changed 4 years ago by tschaub

include "format" parameter in requests

Changed 4 years ago by tschaub

  • state set to Review

This patch adds the required "format" parameter in GetFeatureInfo requests.

Tests pass. Thanks for any review.

Changed 4 years ago by elemoine

Changed 4 years ago by elemoine

2201.2.patch Download corrects a small typo in the API comments ("muse" -> "must").

I wonder if it'd make sense to get the image format from the layer's params, would it give us more chance to use an image format supported by the WMS?

Changed 4 years ago by bartvde

I agree with Eric here, take the FORMAT parameter from the layer's params (it is also what the spec says, *copy* it from the GetMap request). I do not see the point of adding an API property for this.

Changed 4 years ago by bartvde

alternative patch using layer params.FORMAT

Changed 4 years ago by tschaub

  • state changed from Review to Commit

Looks good Bart. Please commit.

Changed 4 years ago by bartvde

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9718]) GetFeatureInfo control does not send required FORMAT parameter, r=tschaub (closes #2201)

Note: See TracTickets for help on using tickets.