Ticket #2117 (closed feature: fixed)

Opened 4 years ago

Last modified 4 years ago

Missing 'exact.' in ArcXML.addValueMapLabelRenderer

Reported by: dzwarg Owned by: tschaub
Priority: blocker Milestone: 2.8 Release
Component: Format Version: 2.8 RC4
Keywords: Cc:
State: Complete

Description

When setting style keys, 'symbol' is a property of 'exact'.

Attachments

missing_exact.patch Download (0.8 KB) - added by dzwarg 4 years ago.
Fix the reference to renderer[key], which should really be 'exact.symbol[key]'
arcims-2117.html Download (2.6 KB) - added by dzwarg 4 years ago.
Test case to demonstrate error.
labeling_bug.png Download (12.7 KB) - added by dzwarg 4 years ago.
Expected behavior of ArcXML format.

Change History

Changed 4 years ago by crschmidt

I don't think this is worth another RC, but if there is one, we can pull it in.

Changed 4 years ago by dzwarg

Oh, there's something else funky going on. I'm investigating.

Changed 4 years ago by dzwarg

Fix the reference to renderer[key], which should really be 'exact.symbol[key]'

Changed 4 years ago by dzwarg

Ok, now it's good.

Changed 4 years ago by tschaub

Yeah, I agree we should stick with regressions from here on out. I'll take a look at this for review.

Changed 4 years ago by tschaub

Change looks simple enough. dzwarg, is there an easy way to see (or test) the difference?

Changed 4 years ago by dzwarg

I'll create a test case and attach it to this ticket.

Changed 4 years ago by dzwarg

Test case to demonstrate error.

Changed 4 years ago by dzwarg

Expected behavior of ArcXML format.

Changed 4 years ago by dzwarg

Attached is a test case .html file. Put this in the /examples/ directory, and please observe 1 error: "symbol is not defined" (in firebug).

Also attached is an image of what the expected result should be -- a few countries labeled with some styling on the map.

Changed 4 years ago by crschmidt

  • keywords pullup added; arcxml removed
  • state changed from Review to Pullup

(In [9474]) Commit bug for missing 'exact' in ArcXML format parser, from dzwarg. Includes manual test. Thanks! (Pullup #2117)

Changed 4 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • state changed from Pullup to Complete
  • resolution set to fixed

(In [9478]) Pullup Changes for 2.8 RC6.

  • VML support for IE8 (Closes #1910)
  • Fix for Opera 9.27 support (Closes #2103)
  • Minor ArcXML change for exact renderer (Closes #2117)
  • Missing semicolons (Closes #2134)
  • vector labels in IE7 standards mode (Closes #2135)
Note: See TracTickets for help on using tickets.