failed to load feed from http://www.instedd.org/

[fredj]

georss from instedd.org throw an error when loaded with Layer.GeoRSS (in the feed title parsing part). Because the first title element is <title />.

The attached patch make the feed title parsing more robust.

georss example:  http://riff.instedd.org/GeoRSSFeed.aspx?social=Swineinfluenza&count=30

[fredj]

Don't crash when parsing feed title, with tests. Tests pass on FF 3.0.10

[fredj]

Please review

[bartvde]

fredj, your testcase does not fail without the change to Layer/GeoRRS, both in FF 3.5.5 as in Safari. Can you explain that? Was this browser specific (IE?). Or has something changed in trunk which makes this change unnecessary?

[fredj]

Replying to bartvde:

fredj, your testcase does not fail without the change to Layer/GeoRRS, both in FF 3.5.5 as in Safari. Can you explain that? Was this browser specific (IE?). Or has something changed in trunk which makes this change unnecessary?

You're right, the test pass without the change but there is an uncaught exception at line 147. This error is not reported and stops the execution of parseData(): the features are not loaded, etc ...

[fredj]

Add a new test (count the features) to show the issue.

[bartvde]

Thanks for the update fredj. The second test fails for me in IE6 though.

fail features count is correct. eq:  values differ: got 0, but expected 3

Also, is it necessary to explicitly return null, since OpenLayers.Util.Try will already return null (If none executes successfully, returns null.).

[fredj]

You're right about the null value, I'll change it.

The test also fails for IE7 but I suspect the georss to be invalid (or the IE parser buggy), the error is not related to the title part.