OpenLayers.String.trim() fails to trim trailing whitespace on multi-line strings

[etdube]

Test case:

var str = "chicken\nHead "; var trimmed = OpenLayers.String.trim(str); // trimmed = "chicken\nHead " ... wrong!

Attached patch replaces the trim regex with the 1st listed at  http://blog.stevenlevithan.com/archives/faster-trim-javascript , which is working for this case and should be efficient enough. Also updates tests/BaseTypes.html with a new testcase.

[etdube]

regex fix for OpenLayers.String.trim()

[etdube]

Bumped the milestone down to 2.8 Release, since the fix is simple and I'd like to use 2.8 for my app. If you don't have time to check this in for the release, feel free to bump it back to 2.9. Thanks.

[tschaub]

Hey etdube, do we have a contributor license agreement from you?

[tschaub]

(In [9255]) Making OpenLayers.String.trim work for multiline strings. Thanks etdube for the patch. r=me (closes #2034)

[tschaub]

Please see HowToContribute for information on submitting a CLA. You can email a copy to the PSC while the paper one is in transit.

[ryangroth5]

I had a problem with this function screwing up Dojo. Dojo assumes that String.prototype.trim is native and the inferior OL version breaks their template system when OL is mixed with Dojo. They use the faster string trim that was cited so this will fix that problem too.

[crschmidt]

ICLA Sent to PSC list.