Vector layer disappears when SelectFeature control is deactivated

[elemoine]

[9116] introduced a regression, making the layer disappear when the SelectFeature control gets deactivated.

The bug can be reproduced with  http://www.openlayers.org/dev/examples/select-feature.html

Use case 1:

• select "draw polygon"
• draw a polygon
• select "select feature"
• select "draw polygon" -> the polygon disappears

Use case 1:

• select "select feature"
• select "draw polygon"
• draw a polygon -> the polygon isn't persisted

[ahocevar]

The above patch fixes the issue. renderer.getRenderLayer() was unable to determine the layer, because it was no longer in the map's layers array. Using layer id now instead, which is always reliable.

On a side note: the only thing that I felt bad about when creating the final patch for #1666 was the fact that renderer.getRenderLayer() failed when the layer is not added to a map. Well, looks like I should have trusted my bad feeling then...

Anyway, Eric, can you please review and confirm if the patch fixes your issue? All tests still pass.

Thanks!

[elemoine]

I can confirm that Andreas' patch fixes the issue. And the patch looks good. Big thanks for fixing this so quickly Andreas! Please commit.

[ahocevar]

(In [9160]) changed the renderer's getRenderLayer method to getRenderLayerId, which always works even if the layer is not added to a map. Also removed an unneeded map.events.unregister from Control.SelectFeature. r=elemoine (closes #2022)