Ticket #2005 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

make namedStyles an array instead of an object

Reported by: dwins Owned by: ahocevar
Priority: minor Milestone: 2.8 Release
Component: Format.SLD Version: 2.7
Keywords: Cc:
State: Complete

Description (last modified by tschaub) (diff)

in the SLD format, namedStyles are treated as an object with one property for each name. Since styles may be duplicated, and order matters, they should be an array instead.

Attachments

namedLayers.patch Download (1.0 KB) - added by tschaub 4 years ago.
untested patch
2005.patch Download (2.3 KB) - added by ahocevar 4 years ago.
with namedLayersAsArray option for read(). Still untested.
2005.2.patch Download (5.1 KB) - added by ahocevar 4 years ago.
patch with tests
2005.3.patch Download (6.0 KB) - added by tschaub 4 years ago.
support namedLayersAsArray option

Change History

Changed 4 years ago by tschaub

untested patch

Changed 4 years ago by tschaub

we could provide a property so that we write the same (array instead of object)

Changed 4 years ago by tschaub

  • description modified (diff)

Changed 4 years ago by ahocevar

  • owner set to ahocevar
  • status changed from new to assigned

Changed 4 years ago by ahocevar

with namedLayersAsArray option for read(). Still untested.

Changed 4 years ago by ahocevar

patch with tests

Changed 4 years ago by ahocevar

  • owner changed from ahocevar to tschaub
  • status changed from assigned to new
  • state set to Review

Patch adds an namedLayersAsArray option to read().

Tests pass in FF3. Thanks for any review.

Changed 4 years ago by tschaub

support namedLayersAsArray option

Changed 4 years ago by tschaub

  • owner changed from tschaub to ahocevar
  • state changed from Review to Commit
  • component changed from general to Format.SLD
  • milestone changed from 2.9 Release to 2.8 Release

Looks good. Thanks for the patch Andreas. I tweaked it just a bit so that you can provide namedLayersAsArray (boy that's a mouthful) as an option when constructing the format and added a test to demonstrate that this works.

If you agree this is good, please commit.

Changed 4 years ago by ahocevar

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9140]) addad namedLayersAsArray option to Format.SLD.v1. Patch by tschaub and me, r=tschaub,me (closes #2005)

Note: See TracTickets for help on using tickets.