Ticket #1928 (new feature)

Opened 4 years ago

Last modified 4 years ago

Destroying popups with abandon - patches to Popup.js and Frame.js

Reported by: openlayers Owned by: euzuro
Priority: minor Milestone: 2.13 Release
Component: Popup Version: 2.7
Keywords: Cc:
State: Needs More Work

Description

Hello,

In some cases I need to "clear the decks" of popups and would like to simply blast away with the destroy() function anywhere that feature.popup is not null. However, when I try this against features that haven't actually created a popup I get several errors.

The attached patches correct the problems in Popup.js and Frame.js.

Thanks, Paul

Attachments

Framed.patch Download (1.1 KB) - added by openlayers 4 years ago.
Popup.patch Download (0.7 KB) - added by openlayers 4 years ago.

Change History

Changed 4 years ago by openlayers

Changed 4 years ago by openlayers

Changed 4 years ago by crschmidt

  • state set to Review

Changed 4 years ago by crschmidt

  • state changed from Review to Needs More Work
  • milestone changed from 2.8 Release to 2.9 Release

I can't reproduce this buggy behavior. Events and the group div are both set in the constructor, so I can't see how a popup can not have an events property. Bumping until we get a test case.

Note: See TracTickets for help on using tickets.