Ticket #1926 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

resetBackBuffer never hides the backbuffer tile

Reported by: ksgeograf Owned by: pagameba
Priority: minor Milestone: 2.8 Release
Component: Tile.Image Version: 2.7
Keywords: resetBackBuffer tiles duplicate Cc:
State: Commit

Description

In Tile/Image.js the comments for "resetBackBuffer" are:

    /** 
     * Method: resetBackBuffer
... omitted lines ....
     *  - If layer is still loading, show foreground tile but don't hide
     *    the backBufferTile yet
     *  - If layer is done loading, reset backBuffer tile and show 
     *    foreground tile
     */

But the code never hides the backbuffer tile. Even when no more tiles are supposed to load (ea this.layer.numLoadingTiles == 0).

I have a map were the overlays are semi-transparent, and this means that the color gets applied twice, making it appear darker.

The attached patch fixes the problem by hiding the backBufferTile.

Attachments

Hide backBufferTile after layer load.diff Download (378 bytes) - added by ksgeograf 4 years ago.

Change History

Changed 4 years ago by ksgeograf

Changed 4 years ago by pagameba

  • owner changed from euzuro to pagameba
  • status changed from new to assigned
  • state set to Review
  • milestone set to 2.8 Release

Thanks Kenneth ... I think this is absolutely right.

Scanning the rest of the code, backBufferTile.hide is only called in two places - first when it is created and second in the transition code around line 507. The resetBackBuffer should hide the backBufferTile as part of resetting it.

Changed 4 years ago by crschmidt

  • status changed from assigned to closed
  • state changed from Review to Commit
  • resolution set to fixed

Committted in r8827

Note: See TracTickets for help on using tickets.