WFS.setOpacity() doen't work properly

[openlayers]

The bug is caused because of the multiple inheritance of Layer.WFS (inheriting from Layer.Vector and Layer.Markers). I presume the intention is to fall back in case the browser doesn't support vector rendering.

The method setOpacity for Layer.Markers is different from that of Layer (which is the parent class of Layer.Vector) and depends on the markers attribute. If WFS is on vectors (myWFS.isVector == true), the overwritten setOpacity method tries to access 'markers' which happen to be empty. And the nasty bugs prevents the rest of the script from running normally.

The solution might be to decide which of the two methods should be used (yep, redundant methods... yikes, but inheriting from more than one class tends to do that). So here is my proposal which seems to run perfect, at least as far as I could test.

/**
 * Resolve the conflict between the method setOpacity() between
 * OpenLayers.Layer.Markers and OpenLayers.Layer.Vector
 */
setOpacity: function(value){
                if (this.vectorMode) {
                    OpenLayers.Layer.Vector.prototype.setOpacity.apply(this, [value]);
                }
                else {
                    OpenLayers.Layer.Markers.prototype.setOpacity.apply(this, [value]);
                }
            },

[openlayers]

patch

[crschmidt]

patch isn't valid, but i'll make it so and test it. this is clearly a mistake on my multiple inheritance stuff.

[crschmidt]

changes setOpacity method, and adds a unit test to make sure it doesn't fail

[elemoine]

crschmidt, your wfs.patch uses OpenLayers.Layer.Vector.prototype.setOpacity in both cases, which doesn't seem right.

[crschmidt]

Good catch, Eric. Fixed.

[elemoine]

I would use call instead of apply here to save the array construction. Anyway, please commit.

[crschmidt]

(In [8952]) Fix for "WFS.setOpacity() doen't work properly". (Closes #1868) r=elemoine