Ticket #1861 (closed bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Move slider to wrong position when click on zoom bar after drag slider

Reported by: avlee Owned by: crschmidt
Priority: minor Milestone: 2.9 Release
Component: Control.PanZoomBar Version: 2.7
Keywords: Cc:
State: Complete

Description

In PanZoomBar control, the slider control handled all mouseup event on map, so after dray slider, if you clik on zoom bar, the slider may be move to wrong position.

Attachments

PanZoomBar.patch Download (0.9 KB) - added by avlee 4 years ago.
1861.patch Download (1.3 KB) - added by tschaub 3 years ago.
better zoom bar behavior

Change History

Changed 4 years ago by avlee

Changed 4 years ago by avlee

  • summary changed from Move slider on wrong position when click on zoom bar after drag slider to Move slider to wrong position when click on zoom bar after drag slider

Changed 4 years ago by crschmidt

  • state set to Awaiting User Feedback
  • milestone changed from 2.8 Release to 2.9 Release

Can't reproduce or understand this one? nor how the patch is supposed to fix it. Please explain more. Bumping to 2.9 for now.

Changed 4 years ago by avlee

Reproduce steps: 1. Open map with PanZoomBar 2. Drag the slider to the max zoom level. 3. Zoom map to new zoom level by click the zoom bar. 4. Try step 3 more times.

Changed 3 years ago by tschaub

  • state changed from Awaiting User Feedback to Review

Here's the simplest way I can reproduce this problem:

1. open controls.html 2. carefully mousedown on the slider handle, mousemove to the top of the slider (without dragging too far up), and mouseup (you should have dragged the slider to the top of the bar) 3. mousedown in the center (vertical and horizontal) of the bar. While holding mousedown, see the map zoom to the appropriate zoom level. 4. mouseup and see the map zoom to a higher zoom level

Changed 3 years ago by tschaub

better zoom bar behavior

Changed 3 years ago by tschaub

I've confirmed that the latest patch fixes the problem for me. I'm going to fix the failing PanZoomBar tests now (been failing for a while), then will confirm that this is good to go.

Changed 3 years ago by tschaub

PanZoomBar tests failing since r9955 (see #2180).

Changed 3 years ago by tschaub

  • state changed from Review to Commit

I've confirmed that this patch improves the PanZoomBar behavior (no more re-zooming on mouseup). Things are working in FF3 and IE6 on the controls.html example and the fractional-zoom.html example. Tests pass with the patch for #2180 applied.

Changed 3 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10025]) Improving the PanZoomBar behavior so that when you click on the bar after dragging to the top, the map doesn't re-zoom on mouse up. r=me (closes #1861)

Changed 3 years ago by tschaub

Thanks for the patch avlee. Do we have a contributor license agreement on file from you?

Note: See TracTickets for help on using tickets.