Ticket #1834 (closed feature: fixed)

Opened 5 years ago

Last modified 4 years ago

the cluster strategy doesn't listen on the proper event type

Reported by: elemoine Owned by: elemoine
Priority: major Milestone: 2.8 Release
Component: Strategy.Cluster Version: 2.7
Keywords: Cc:
State: Complete

Description

the cluster strategy listen on the map's zoomend event, instead it should listen to its layer's moveend event, to avoid cases where the strategy runs the clustering logic while the layer is invisible or out of range

Attachments

patch-1834-r8356-A0.diff Download (1.4 KB) - added by elemoine 5 years ago.
1834.patch Download (2.1 KB) - added by tschaub 5 years ago.
register for events on the layer instead of the map

Change History

Changed 5 years ago by elemoine

Changed 5 years ago by elemoine

patch-1834-r8356-A0.diff is absolutely untested, and there for our cluster strategy bug finders to give it a try

depends on #1831 (not strictly)

Changed 5 years ago by elemoine

  • state set to Awaiting User Feedback

Changed 5 years ago by tschaub

  • state changed from Awaiting User Feedback to Review

Feedback was  positive.

Changed 5 years ago by tschaub

register for events on the layer instead of the map

Changed 5 years ago by tschaub

  • state changed from Review to Commit

Tests only pass with the patch for #1831. And, they only pass with the second patch. There is some weird behavior going on with event registration that causes tests to fail with the first patch.

The change to the Cluster test is a regression test against #1831. Tests pass with and without this change (given the changes to the cluster strategy). That, and the fact that the example still works are enough for me to say this is good to go.

Changed 4 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [8460]) Cluster strategy should register for moveend on the layer instead of zoomend on the map. p=elemoine,me r=me (closes #1834)

Note: See TracTickets for help on using tickets.