SelectFeature should allow panning the map when over features, without activating click method at the end of drag

[igrcic]

In addition to problem mentioned here:  http://www.nabble.com/Re%3A-SelectFeature-hover-control-interfering%09with-click-and-drag-td19365814.html#a20357439

there should be an option to block click occuring after the map is dragged (while mouse is over feature). It can be achieved by adding one more property, such as clickTolerance.

Patch supplied, tnx to Eric ;)

[crschmidt]

Do we need a seperate tolerance for click/clickout? seems like they'd always be the same to me, since they're simply working around the same behavior. I'd say that this patch should be rewritten to just use the same property for both (Which simplifies the patch considerably, I think)

[elemoine]

Chris, yes but I was concern with backward compatibility if we were to rename the property from clickoutTolerance to clickTolerance.

[tschaub]

The clickoutTolerance is not marked API. If we're really talking about a single property, I think we should save ourselves the work of rewriting this later - and rename it now. I think a wiki page, email warning, and notes with the release would be sufficient (but I imagine others are more conservative about changing things).

[crschmidt]

I'm with Tim. Change it. (Even if it was API I might be willing to, but since it's not, I'm all over that.)

[elemoine]

Replying to crschmidt:

I'm with Tim. Change it. (Even if it was API I might be willing to, but since it's not, I'm all over that.)

agreed, i'll update the patch when i get a chance

[crschmidt]

Eric:

I'm setting a deadline of April 1 on new non-regression patches. If there's nothing new here by then, it'll get bumped. If you don't think you can fit it in that time, please comment here and someone else may be able to grab it.

[elemoine]

patch-1824-r9145-A0.diff

New patch, with tests. Relevant tests pass on FF3. Thanks for any review.

[tschaub]

clickTolerance

[tschaub]

Thanks for the patch Eric. I think this looks good. My patch just corrects a typo (clicTolerance in docs) and a bit of math (square root of 8 is not 4 :).

Please commit.

[elemoine]

(In [9194]) SelectFeature should allow panning the map when over features, without activating click method at the end of drag, r=tschaub (closes #1824)