Ticket #1747 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Layer.GML has some problems with load events

Reported by: bartvde Owned by: crschmidt
Priority: minor Milestone: 2.8 Release
Component: Layer.GML Version: 2.6
Keywords: Cc:
State: Complete

Description (last modified by tschaub) (diff)

Btw there is no Layer.GML Trac component.

Hi Bart. Here's my (late) response: I think you're right, it'd be
better to have loadGML trigger the loadstart event. Maybe a ticket
should be open for this. Thanks. Eric

2008/8/26, Bart van den Eijnden (OSGIS) <bartvde@address-obscured>:
> > Hi list,
> >
> > http://trac.openlayers.org/browser/trunk/openlayers/lib/OpenLayers/Layer/GML.js
> >
> > Any reason why the loadstart event is not trigger in the loadGML
> > function itself?
> >
> > Now it is triggered in moveTo, setURL but for instance not in
> > setVisibility before the loadGML call.
> >
> > Would it not be better to move the event to the loadGML function, and
> > specifically inside the if block?
> >
> > If I read the current code correctly, if the layer is already loaded,
> > won't it fire a loadstart but not a loadend?
> >
> > Best regards,
> > Bart
> >

Attachments

loadstart.patch Download (0.9 KB) - added by crschmidt 4 years ago.

Change History

Changed 4 years ago by crschmidt

Changed 4 years ago by crschmidt

  • state set to Review
  • milestone set to 2.8 Release

Changed 4 years ago by elemoine

  • state changed from Review to Needs More Work

the Layer.GML tests fail on ff3 fail with the patch applied (sorry i have no time for correcting the problem)

Changed 4 years ago by crschmidt

Eric,

I can't reproduce this. Can you copy paste the error text or something so I can try to figure out why it's happening? Thanks.

Changed 4 years ago by crschmidt

  • state changed from Needs More Work to Review

Since I know elemoine is busy right now, I'm going to ask if someone else can comment here if they can apply the patch; I've tried on FF3 and IE, and had no luck reproducing.

Changed 4 years ago by tschaub

  • state changed from Review to Commit

I can imagine the test failing if the 1s delay is not long enough, but I am not getting failures here either. This looks good. We'll hear about it before the release if there is a real problem.

Changed 4 years ago by tschaub

  • description modified (diff)

Changed 4 years ago by tschaub

  • owner changed from euzuro to crschmidt
  • component changed from Layer to Layer.GML

Changed 4 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9050]) fix for Layer.GML has some problems with load events r=tschaub (Closes #1747)

Note: See TracTickets for help on using tickets.