Ticket #174 (closed bug: fixed)

Opened 7 years ago

Last modified 7 years ago

typo in WMS.js

Reported by: tschaub Owned by: euzuro
Priority: minor Milestone: 2.0 Release
Component: Layer Version:
Keywords: Cc:
State:

Description

The constructor in WMS.js checks this.params.TRANSPARENT instead of params.TRANSPARENT. I think this is wrong. I could be mistaken though.

Attachments

WMS.js.patch Download (353 bytes) - added by tschaub 7 years ago.
params.TRANSPARENT instead of this.params.TRANSPARENT
WMS.js.2.patch Download (356 bytes) - added by tschaub 7 years ago.
test for true instead of "true"

Change History

Changed 7 years ago by tschaub

params.TRANSPARENT instead of this.params.TRANSPARENT

Changed 7 years ago by tschaub

Apologies for the hasty ticket - that wasn't the problem...

Changed 7 years ago by tschaub

test for true instead of "true"

Changed 7 years ago by tschaub

Ok, I think the second patch solves the problem. Looks like the test should be for true instead of "true".

Changed 7 years ago by euzuro

  • status changed from new to closed
  • resolution set to fixed

in the HTTPRequest constructor, we make a copy of params into this.params, so the first patch is not quite necessary.

The later patch, regarding true and "true", has been incorporated. Thanks for spotting that!

Changed 7 years ago by euzuro

  • milestone set to 2.0 Release
Note: See TracTickets for help on using tickets.