Ticket #1732 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

VML rendering may fail to draw geometries when coordinate numbers are very high

Reported by: ahocevar Owned by:
Priority: minor Milestone: 2.7 Release
Component: Renderer.VML Version: 2.7 RC1
Keywords: Cc:
State: Complete

Attachments

1732-r7995-A0.patch Download (5.6 KB) - added by ahocevar 5 years ago.

Change History

Changed 5 years ago by ahocevar

  • state set to Awaiting User Feedback

The above patch is a first attempt to fix it.

Changed 5 years ago by ahocevar

  • type changed from feature to bug

Changed 5 years ago by ahocevar

Changed 5 years ago by euzuro

Hi team. Is this a regression?

If so, please file it under the 2.7 Milestone. If not, let's put it under 2.8 please. Thanks!

Changed 5 years ago by ahocevar

  • milestone set to 2.7 Release

This is not a regression, but it kind of finishes up the renderer improvements. And because the changes only affect the geometry coordinates in the VML renderer, a visual test on any of the vector examples is enough to ensure that it works and does not cause regressions.

It would, however, be great to get user feedback on that, because I have no test case to see if the patch really fixes the issue.

Changed 5 years ago by ahocevar

  • state changed from Awaiting User Feedback to Review

User BrainDrain reports that the patch fixes his issue.

Relevant tests pass in IE6 and IE7. Thanks for any review.

Changed 5 years ago by tschaub

  • state changed from Review to Commit

Looks ok to me. So (with a bit of faith), please commit.

Changed 5 years ago by ahocevar

  • keywords pullup added
  • state changed from Commit to Pullup

(In [8004]) use a local coordinate system starting at (0,0) instead of coordinates just derived from the geometries, resetting it every time the resolution changes. r=tschaub (Pullup #1732)

Changed 5 years ago by euzuro

  • keywords pullup removed
  • status changed from new to closed
  • state changed from Pullup to Complete
  • resolution set to fixed

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)

Note: See TracTickets for help on using tickets.