Give Popups an 'closeOnPan' Option

[euzuro]

When closeOnPan is true, the popup disappears when the map moves.

[jrf]

So I figured that [8173] would be the only thing needed to implement this, but then it turns out that onMove is never called...

grep -r onMove * | grep "js:"

lib/OpenLayers/Popup.js: /** Method: onMove

lib/OpenLayers/Popup.js: onMove: function(){

lib/OpenLayers/Popup.js: OpenLayers.Console.log("onMove");

and similar results for grep -r Move *

So, what am I missing about how the popup's position is updated?

[jrf]

Doh. That onMove function was something I added. Taking that out and doing this.map.events.register inside the draw() method works well. Patch attached.

[elemoine]

listener unregistration should be done eventually, probably when the popup is destroyed. Events are good, but we should be careful not to forget about unregistering listeners.

[euzuro]

new patch. includes tests (all pass on ff2 & ie7), a mod to the popups.html example to show it in action, and the requested unregistering in the destroy()

[euzuro]

all tests pass ff2/ie7. please review

[crschmidt]

Erik,

The "unregister" in destroy is actually a register.

[euzuro]

take three -- thanks for spotting the [un]register flub, chris

[fredj]

The popup is closed on pan and zoom ? I suggest to rename the attribute from 'closeOnPan' to 'closeOnMove'. (but I'm maybe too pedantic ...)

[crschmidt]

Simple enough, though I agree that fred's name makes more sense. Feel free to commit closeOnMove.patch.

[euzuro]

(In [8397]) give popups a 'closeOnMove' option. if set to true, the popup will close itself as soon as the map is pan/zoom (move)ed. patch by jrf, euzuro review by elemoine, cr5. (Closes #1726)