Vector feature redrawn offscreen stays invisible

[jstern81]

Windows XP Firefox 3

Vector features with external graphics which are redrawn offscreen remain invisible when they are panned back onscreen, and remain so until a zoom change. This issue reared itself when a selected feature was panned offscreen, unselected, and then panned back onscreen.

See an example at:  http://t2gnow.com/ol/offscreen-feature-redraw/example.html Click to select, pan the feature offscreen, click the map to unselect, then pan the map back to where it should have been. Alternatively, pan the feature offscreen, click the 'draw feature' link to force a redraw, and then pan back to where the feature should be.

[ahocevar]

jstern81: can you please apply the above patch and see if it fixes your issue?

[ahocevar]

Ok, this issue is obvious because we do not handle the unrenderedFeatures in the drawFeature method. The above patch fixes this, resulting (as a side effect) in more compact and better readable code. (Relevant) tests still pass in FF2/3 and IE7. Please review.

[jstern81]

Cool, works great and code looks nicer as you say. Could also get rid of the now extraneous local unrenderedFeatures in moveTo:

            if(!zoomChanged && coordSysUnchanged) {
                var unrenderedFeatures = {};

[ahocevar]

Removed no longer needed local unrenderedFeatures variable

[ahocevar]

Thanks jstern81, I missed that one.

[elemoine]

Looks good to me. Please commit.

[ahocevar]

(In [7976]) moved handling of unrenderedFeatures from moveTo to drawFeature. r=elemoine (pullup #1723)

[euzuro]

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)