Ticket #1718 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

backgroundGraphic icon not deleted after feature destroy

Reported by: guillaume Owned by: crschmidt
Priority: minor Milestone: 2.7 Release
Component: Layer.Vector Version: 2.6
Keywords: Cc:
State: Complete

Description


Attachments

1718-r7946-A0.patch Download (0.6 KB) - added by ahocevar 5 years ago.

Change History

Changed 5 years ago by ahocevar

Changed 5 years ago by ahocevar

guillaume, please let me know if the above patch fixes your issue.

Changed 5 years ago by ahocevar

  • state set to Review
  • milestone set to 2.7 Release

There was no user feedback, but this one is a regression from r7781. The problems occurs if you are using backgroundGraphic without an indexer (which is absolutely valid to do).

Please review.

Changed 5 years ago by crschmidt

  • state changed from Review to Commit

Andreas,

Looks good. Please commit and "(Pullup #1718)"

Changed 5 years ago by ahocevar

  • keywords pullup added
  • state changed from Commit to Pullup

(In [7996]) Make sure that backgroundGraphic icon is deleted on feature destroy, even if no indexer is being used. r=crschmidt (Pullup #1718)

Changed 5 years ago by ahocevar

r7997 modifies the Renderer/Elements.html tests to provide a valid environment for this to work.

Changed 5 years ago by euzuro

  • keywords pullup removed
  • status changed from new to closed
  • state changed from Pullup to Complete
  • resolution set to fixed

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)

Note: See TracTickets for help on using tickets.