Ticket #1634 (closed feature: fixed)

Opened 5 years ago

Last modified 4 years ago

draw feature control should pass temporary rendering intent to sketch handler

Reported by: tschaub Owned by: elemoine
Priority: major Milestone: 2.8 Release
Component: Style Version: 2.6
Keywords: Cc:
State: Complete

Description

Currently, the sketch handlers check a style property that is expected to be a symbolizer object. This should become an OL.Style object (or should work with one).

Attachments

temp_intent.patch Download (1.6 KB) - added by tschaub 4 years ago.
pass along the temporary style

Change History

  Changed 5 years ago by euzuro

  • state set to Needs More Work

  Changed 5 years ago by euzuro

warning: this is getting moved to 2.8 unless it can gets reviewed and committed in the next 30 hours or so....

  Changed 5 years ago by euzuro

  • owner changed from ahocevar to elemoine

  Changed 5 years ago by euzuro

eric can you take a look at this one?

  Changed 5 years ago by elemoine

  • milestone changed from 2.7 Release to 2.8 Release

I'd say that this isn't a must-have for 2.7.

  Changed 4 years ago by tschaub

(In [8746]) If the destination layer for a sketch has a style map, make the style for the temporary rendering intent on that layer the style used by the temporary layer of the sketch handlers (see #1634).

Changed 4 years ago by tschaub

pass along the temporary style

follow-up: ↓ 8   Changed 4 years ago by crschmidt

  • state changed from Needs More Work to Commit

Looks good to me, and worked in my local tests. Please commit unless there's some reason not to... For the record, the changes to point look like they already went in with r8831...

in reply to: ↑ 7   Changed 4 years ago by tschaub

Replying to crschmidt:

Looks good to me, and worked in my local tests. Please commit unless there's some reason not to... For the record, the changes to point look like they already went in with r8831...

Thanks for the review. The r8831 Point.js slip was bad patching on my part.

  Changed 4 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [8890]) Passing the temporary rendering intent to the temporary sketch layer. Related Point.js changes in r8831. r=elemoine (closes #1634)

Note: See TracTickets for help on using tickets.