Ticket #1624 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

cursor "inherit" on a vector feature causes IE to load cursor file "inherit"

Reported by: ahocevar Owned by:
Priority: blocker Milestone: 2.7 Release
Component: Feature.Vector Version: 2.6
Keywords: Cc:
State: Complete

Description

Obviously VML does not recognize the "inherit" keyword from css. In SVG, this works fine.

The attached patch adds an additional check for the value "inherit" before setting the cursor value.

Attachments

1624-r7551-A0.patch Download (0.7 KB) - added by ahocevar 5 years ago.

Change History

Changed 5 years ago by ahocevar

  Changed 5 years ago by ahocevar

  • state set to Review
  • milestone set to 2.7 Release

  Changed 5 years ago by pgiraud

  • state changed from Review to Commit

If you can confirm that tests pass, I'm ok with this patch. Performances are back !

  Changed 5 years ago by ahocevar

Tests pass in FF2 and IE6. This issue (thanks pgiraud for spotting it) seems to be the reason for the recent complaints abourt vector performance in IE. I just ran tha manual vector-features-performance.html test, and it is ~8 times faster with this fix.

  Changed 5 years ago by ahocevar

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7554]) don't set the cursor to "inherit" in the VML renderer. r=pgiraud (closes #1624)

  Changed 5 years ago by euzuro

  • component changed from general to Renderer.VML

  Changed 5 years ago by fvanderbiest

  • priority changed from minor to blocker
  • resolution fixed deleted
  • status changed from closed to reopened
  • component changed from Renderer.VML to Feature.Vector

I reopen this ticket because it happens again on IE with OpenLayers.Feature.Vector.styledefault? and OpenLayers.Feature.Vector.styletemporary? specifying cursor: "inherit".

Replacing "inherit" by "pointer" stops the calls to /inherit on the server when IE is being used (which is pretty weird !)

follow-up: ↓ 8   Changed 5 years ago by ahocevar

  • state changed from Complete to Awaiting User Feedback

What version of OpenLayers are you using? I just checked in current trunk and the 2.7rc1 branch, and in both the code that prevents this behaviour is still there.

in reply to: ↑ 7   Changed 5 years ago by fvanderbiest

  • status changed from reopened to closed
  • state changed from Awaiting User Feedback to Complete
  • resolution set to fixed

I'm currently stuck at r7479. As it was fixed in r7554, this explains why it happens. Sorry for the "noise".

Replying to ahocevar:

What version of OpenLayers are you using? I just checked in current trunk and the 2.7rc1 branch, and in both the code that prevents this behaviour is still there.

Note: See TracTickets for help on using tickets.