Ticket #1616 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

[REGRESSION] extra '?' is added to the URL by the LoadURL method.

Reported by: openlayers Owned by:
Priority: minor Milestone: 2.7 Release
Component: Ajax Version: 2.6
Keywords: Cc:
State: Complete

Description

some URL like this : ../mapview/info/?X=314.99999999999983&Y=305.0000000000039&BBOX=337918.13584105,7652844.79930825,378081.86415895,7681155.20069175&WIDTH=759&HEIGHT=535&layers=9,4,5

is sent like this : ../mapview/info/?X=314.99999999999983&Y=305.0000000000039&BBOX=337918.13584105,7652844.79930825,378081.86415895,7681155.20069175&WIDTH=759&HEIGHT=535&layers=9,4,5?

to the server by the LoadURL method.

Attachments

patch-1616-r7487-A0.diff Download (0.8 KB) - added by elemoine 5 years ago.
params.patch Download (3.0 KB) - added by tschaub 5 years ago.
extend existing query string with & and don't append ? if params is empty

Change History

Changed 5 years ago by elemoine

Changed 5 years ago by elemoine

Guillaume, can you try the attached patch and change the ticket state to Review if it works for you. Thx.

Changed 5 years ago by elemoine

  • state set to Awaiting User Feedback

Changed 5 years ago by crschmidt

  • milestone set to 2.7 Release

Regression against 2.6

Changed 5 years ago by crschmidt

  • state changed from Awaiting User Feedback to Review

Changed 5 years ago by crschmidt

  • summary changed from extra '?' is added to the URL by the LoadURL method. to [REGRESSION] extra '?' is added to the URL by the LoadURL method.

Changed 5 years ago by tschaub

extend existing query string with & and don't append ? if params is empty

Changed 5 years ago by tschaub

  • state changed from Review to Commit

Made an additional change so that given a url like  http://example.com/?existing=query doesn't get an extra ? separator when a request is issued with params.

Changed 5 years ago by elemoine

  • keywords LoadURL removed
  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7984]) Fix for "extra '?' is added to the URL by the LoadURL method", review and final patch from tschaub (closes #1616)

Changed 5 years ago by elemoine

  • keywords pullup added
  • state changed from Complete to Pullup

Changed 5 years ago by crschmidt

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 5 years ago by euzuro

  • keywords pullup removed
  • status changed from reopened to closed
  • state changed from Pullup to Complete
  • resolution set to fixed

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)

Note: See TracTickets for help on using tickets.