Ticket #1614 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

GeoRSS, States Misplaced

Reported by: tcoulter Owned by:
Priority: critical Milestone: 2.7 Release
Component: Format.GeoRSS Version: 2.6
Keywords: Cc: dwinslow@…
State: Complete

Description

David Winslow at TOPP stumbled across this one while doing some GeoRSS Geoserver work. It seems that, in the edited georss example below, states show up misplaced. To show off this bug, he's created an example where Arkansas appears in the middle of the Atlantic Ocean!. He also provides a link to Google Maps using the same data set (just Arkansas), where it shows up in the correct place.

See the following link for a better representation of the problem:  http://geo.openplans.org/~dwinslow/arkanwhere.png

David's GeoRSS data set is here:  http://geo.openplans.org/~dwinslow/arkansas.rss
And his map configuration/example is here:  http://geo.openplans.org/~dwinslow/georss-markers.html

And here's Google Maps as an oracle:

 http://tinyurl.com/636dv7

Looks like there's an OL bug in there somewhere.

IMPORTANT NOTE: If you look at David's georss-example, it seems that the bug is variable. Sometimes Arkansas shows up in the correct spot, sometimes it doesn't. It's not completely obvious as to why. Refresh the page a bit if Arkansas does not seem misplaced.

I've CC'd David on this ticket. Please refer questions to him.

Attachments

concatChildValues.patch Download (12.4 KB) - added by crschmidt 5 years ago.

Change History

Changed 5 years ago by crschmidt

Firefox splits XML nodes at 4k boundaries: arkansas, in this case, is more than 4k. We need to use concatChildNodes from Format.XML in the Format.GeoRSS parser, but we don't. There was a recent post on the mailing list which failed due to the same problem.

If someone wants to fix it, I can help point you where to go to fix it.

Changed 5 years ago by euzuro

  • milestone set to 2.7 Release

seems like this ought to be at least worth considering for 2.7

Changed 5 years ago by crschmidt

  • priority changed from minor to critical
  • status changed from new to assigned

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

  • owner changed from crschmidt to tschaub
  • status changed from assigned to new
  • state set to Review

Changed 5 years ago by crschmidt

  • owner tschaub deleted

Changed 5 years ago by ahocevar

  • state changed from Review to Commit
  • component changed from Layer.GeoRSS to Format.GeoRSS

This looks good. Please commit.

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7871]) GeoRSS fails on large line/poly nodes in FF. Use concatChildNodes to get all the text into one string before parsing. Includes manual test. r=ahocevar. (Closes #1614)

Note: See TracTickets for help on using tickets.