Ticket #1612 (closed feature: invalid)

Opened 5 years ago

Last modified 4 years ago

Layer.Yahoo and Layer.WFS don't play well together

Reported by: elemoine Owned by: elemoine
Priority: major Milestone: 2.8 Release
Component: Layer.Yahoo Version: SVN
Keywords: Cc:
State:

Description

Carole Zieler reported an error with a map using a Yahoo layer and a WFS layer. The error is:

position has no properties
this.position = position.clone();

It occurs on every moveTo to the WFS layer.

Based on code she gave me I could write a stripped down example and reproduce the problem. See carole.html.

I have no idea what the problem is. I could just find out that the cause of the problem is the Yahoo convertLatLonXY func (called in Layer.Yahoo::getMapObjectPixelFromMapObjectLonLat) returning false instead of a pixel object.

Attachments

carole.html Download (2.0 KB) - added by elemoine 5 years ago.
wfs.patch Download (0.6 KB) - added by crschmidt 5 years ago.

Change History

Changed 5 years ago by elemoine

Changed 5 years ago by crschmidt

Yahoo's API doesn't let you get a latlon from a pixel when the pixel is outside the viewport area -- this might be the problem, if you dragged the map far enough that it was outside the viewport area or something?

Just a comment/guess, no real investigatoin on my part.

Changed 5 years ago by elemoine

crschmidt, the problem doesn't occur in a pixel-to-lonlat conversion but in lonlat-to-pixel conversion (convertLatLonXY).

Changed 5 years ago by crschmidt

  • owner changed from euzuro to crschmidt
  • priority changed from major to critical
  • status changed from new to assigned

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

  • state set to Needs More Work

Elemoine:

Give this a try and see if it helps. Sine we never use the pos of WFS tiles (it's largely meaningless) I think we can just fake it, and drop the call that fails from the WFS layer.

(This will all go away with vector behavior, of course.)

Changed 5 years ago by crschmidt

  • priority changed from critical to major

Changed 5 years ago by crschmidt

  • owner changed from crschmidt to elemoine
  • status changed from assigned to new

Changed 5 years ago by euzuro

  • state changed from Needs More Work to Review

Changed 5 years ago by euzuro

  • milestone changed from 2.7 Release to 2.8 Release

Unclear exactly what I am supposed to do/see in carole.html related to this bug, but I do get script errors, even with this patch applied.

Unless someone is dying for this to get in, it's going to 2.8

Changed 4 years ago by crschmidt

  • status changed from new to closed
  • state Review deleted
  • resolution set to invalid

So, I've just tried this example, and tried to reproduce the underlying problem. I definitely had something I could reproduce before, and now I can't -- I believe this is because Yahoo!'s API changed. (That's nice, since I've only been asking for that for a long time.) So, I think that Yahoo!'s API updates have made this no longer valid.

Note: See TracTickets for help on using tickets.