Ticket #1600 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

getChildValue() on GeoRSS format is slow

Reported by: edgemaster Owned by: edgemaster
Priority: minor Milestone: 2.7 Release
Component: Format.GeoRSS Version: SVN
Keywords: Cc:
State: Complete

Description

The getChildValue function on Format.GeoRSS seriously slows down parsing of large documents (~100 features) The firebug profiler says that each call is averaging 5.57ms, with max of 500ms, totalling 2785ms for 500 calls.

On a hunch, I patched the function to not use an exception handler, this resulted in a considerable speedup, avg 0.406ms, max 0.908ms, total 118.442ms for the same 500 calls.

Attached is a testcase and patch to current trunk, georss tests pass.

Attachments

t1600r7419.Format.GeoRSS.patch Download (0.7 KB) - added by edgemaster 5 years ago.
Patch to Format.GeoRSS
georssGCVtest.htm Download (1.0 KB) - added by edgemaster 5 years ago.
Testcase (for fx2 & fb1.2)
planning.georss Download (78.9 KB) - added by edgemaster 5 years ago.
georss for testcase

Change History

Changed 5 years ago by edgemaster

Patch to Format.GeoRSS

Changed 5 years ago by edgemaster

Testcase (for fx2 & fb1.2)

Changed 5 years ago by edgemaster

georss for testcase

Changed 5 years ago by edgemaster

  • state set to Review

Changed 5 years ago by elemoine

Patch looks good to me. I'll go ahead and commit it if there's no push back in the coming days. Thanks edgemaster.

Changed 5 years ago by crschmidt

+1

Changed 5 years ago by edgemaster

  • owner set to edgemaster
  • status changed from new to assigned

(Just accepting as my ticket for later reference)

Changed 5 years ago by elemoine

Except one unrelated error in Lang.html, all unit tests pass on FF2.

Changed 5 years ago by elemoine

  • status changed from assigned to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [7468]) getChildValue() on GeoRSS format is slow, p=edgemaster, r=me,crschmidt (closes #1600)

Note: See TracTickets for help on using tickets.