Ticket #1581 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

there are missing @requires for the new XHR

Reported by: pgiraud Owned by:
Priority: minor Milestone: 2.7 Release
Component: Ajax Version: 2.6
Keywords: Cc:
State: Complete

Description

Building OpenLayers seems to be broken with the new XHR code. Error is : "OpenLayers.Request has no properties". In fact, OpenLayers.Request doesn't exist.

It seems to me like there are missing @requires in some classes comments. In my opinion, the @requires for Ajax should have been replaced.

Attachments

patch-1581-r7335-A0.diff Download (1.4 KB) - added by pgiraud 5 years ago.

Change History

Changed 5 years ago by pgiraud

Changed 5 years ago by pgiraud

The attached patch (A0) fixes the issue in the case I'm working on. Though, I have the feeling that there are other several files in which the @requires for OpenLayers/Request.js is missing (for example OpenLayers/Tile/WFS.js).

Changed 5 years ago by elemoine

  • state set to Commit
  • type changed from feature to bug
  • milestone set to 2.7 Release

Looks good.

Changed 5 years ago by elemoine

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7336]) there are missing @requires for the new XHR, patch from pgiraud, r=me (closes #1581)

Changed 5 years ago by tschaub

  • status changed from closed to reopened
  • resolution fixed deleted

As discussed elsewhere, we'll make these requires point to the XMLHttpRequest.js script instead.

Changed 5 years ago by tschaub

  • status changed from reopened to closed
  • resolution set to fixed

(In [7339]) For now, we will point the requires directive at the XMLHttpRequest.js script. (closes #1581)

Note: See TracTickets for help on using tickets.