Ticket #1570 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Util.getRenderedDimensions improperly sets style width and height

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.7 Release
Component: Util Version: 2.6
Keywords: Cc:
State: Complete

Description

Units need to be specified for style width and height. Thanks to Wally Atkins for email report.

Attachments

grd.patch Download (1.6 KB) - added by tschaub 5 years ago.
use units when setting style width and height

Change History

Changed 5 years ago by tschaub

use units when setting style width and height

Changed 5 years ago by tschaub

  • state set to Review
  • type changed from feature to bug

All tests pass in FF.

Changed 5 years ago by euzuro

  • owner set to euzuro
  • status changed from new to assigned

this is an excellent bug find. great find, Wally!!!

also kudos tim for transforming this into a patch.

i have to run now, but i'll be running tests and approving this first thing in the morning.

vive l'open source!

Changed 5 years ago by euzuro

  • owner changed from euzuro to tschaub
  • status changed from assigned to new
  • state changed from Review to Commit

ok. patch passes all tests in ie7 (except layer.text, which i am sure is unrelated) and ff2.

again, *great* debugging work. solid fix for the new popups.

please commit

Changed 5 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7329]) Fixing Util.getRenderedDimensions so it assigns units to positional values. Thanks Wally for the report. r=euzuro (closes #1570)

Note: See TracTickets for help on using tickets.