Set the imageSrc before the supper class initialzed in FramedCloud popup

[avlee]

In current trunk, should set the imageSrc before the supper class initialzed in FramedCloud popup.

[elemoine]

avlee's patch seems valid to me, but I'd like to get another opinion before we commit it into trunk

Thanks avalee

[ahocevar]

Not sure about this patch. I think that this.imageSrc should be set in Popup.Framed. Looks to me as this assignment is entirely missing there.

[ahocevar]

	<elemoine>	ahocevar: what value would you give to imageSrc in Framed?
	<ahocevar>	elemoine: first, I have to admit that this is the first time for me looking into the new popup code.
	<elemoine>	ahocevar: same here ;-)
	<ahocevar>	But the way it is done now would only make sense if Popup.Framed is some kind of abstract class, which I don't know if it is.
	<elemoine>	I'm wondering if Popup.Framed is something people can use or just an abstract class
	<elemoine>	agreed
	<ahocevar>	so let's assume it is an abstract class.
	<ahocevar>	In that case, avlee's patch should at least not do any harm.
	<ahocevar>	(in every other case neither, but then something else might be wrong)
	<elemoine>	yep
	<elemoine>	it's even a good fix AFAICT
	<elemoine>	right now, imageSrc isn't taken into account when the Framed class constructor is called
	<elemoine>	which doesn't look correct
	<ahocevar>	yes. so the patch seems to be good.
	<ahocevar>	I don't see anything wrong about it.
	<elemoine>	me neither
	<elemoine>	I think the patch fixes the case when fixedRelativePosition is true (which isn't the default)
	<elemoine>	when fixedRelativePosition is false, Framed.createBlocks (which uses imageSrc) isn't called in the constructor but when setSize is called}}}
The patch looks good. Only one thing to mention: If Popup.Framed is not supposed to be an abstract class, then something might be wrong there (probably unrelated to this ticket).

[ahocevar]

Sorry for the bad formatting in the above comment. Here's the one important bottom line again:

The patch looks good. Only one thing to mention: If Popup.Framed is not supposed to be an abstract class, then something might be wrong there (probably unrelated to this ticket).

[ahocevar]

modified patch. imageSrc is already defined as property in Popup.Framed

[ahocevar]

(In [6750]) Set the imageSrc bevore the super class is initialized in Popup.FramedCloud. Thanks avlee. r=elemeoine,me (closes #1475)

[ahocevar]

Is this good to pullup?

[ahocevar]

(In [6751]) now also committed the removal of the imageSrc property definition in Popup.FramedCloud. avlee's original patch is perfectly sane. Sorry for the confusion. Thanks elemoine for the hint. (references #1475)

[ahocevar]

That's the patch that finally made it into trunk (can be used for pullup to 2.6)

[crschmidt]

(In [6752]) avlee, elemoine, and ahocevar point out that we should change the initialization of the imageSrc property to be *before* we call the superclass. This pullup (Closes #1475), and is the last thing I'm going to touch before the 2.6 release. svn merge -r6749:6751 trunk branch.