Ticket #1463 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

SVG support for Safari 3.1

Reported by: openlayers Owned by:
Priority: blocker Milestone: 2.6 Release
Component: Renderer Version: SVN
Keywords: Cc: sypasche
State: Complete

Description

OpenLayers returns the error "Your browser does not support vector rendering" if rendering vector graphics with Safari 3.1. Safari 3.0 works. Verified with Mac OS 10.4 and Windows XP. Verified also with OpenLayers 2.5.

Attachments

svg.supported.patch Download (0.9 KB) - added by crschmidt 5 years ago.
add BasicStructure test, confirmed to pass in Safari nightly, suggested by #17400

Change History

  Changed 5 years ago by crschmidt

Ugh, I was really hoping they wouldn't ship with this behavior. What a pain.

We need ot change our supported() call to do something different for Safari.

  Changed 5 years ago by sypasche

That should be fixed in WebKit now:  http://bugs.webkit.org/show_bug.cgi?id=10297

This page might be useful for selecting the feature to check:  http://www.din.or.jp/~hagi3/JavaScript/JSTips/Mozilla/Samples/hasFeature.htm (I don't have a Safari 3.1 handy to check).

  Changed 5 years ago by sypasche

  • cc sypasche added

follow-up: ↓ 9   Changed 5 years ago by crschmidt

sypasche: You'll need to add a full email address to get CCs. Sorry.

Can you define "fixed"? Webkit is now *accurate*: it still returns false for our current test.

Changed 5 years ago by crschmidt

add BasicStructure test, confirmed to pass in Safari nightly, suggested by #17400

  Changed 5 years ago by crschmidt

  • state set to Review

 http://bugs.webkit.org/show_bug.cgi?id=17400 suggests the use of BasicStructure instead: use that in addition to our current checks. Confirmed in Safari 3.1 on Windows, and Safari nightly on Mac.

  Changed 5 years ago by crschmidt

Tests continue to pass in FF, and shouldn't affect IE at all (since document.implementation check will return false and bail out of the test early), and work in Safari 3.0 as well.

  Changed 5 years ago by pspencer

  • state changed from Review to Commit

I applied the patch and tried out some of the vector examples manually with Safari 3.1 and things are working. Without the patch, I get the error message. I also tried it in ff2 on "os x" and the examples work. I didn't run the tests, but I am happy with this change and I think you should go ahead and commit.

  Changed 5 years ago by crschmidt

  • keywords Safari SVG removed
  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [6581]) Add support for Safari 3.1 SVG version strings: Safari got more 'honest' about what it supports, at the cost of breaking OpenLayers Vector layers. This looks for a more 'basic' SVG featureset, as recommended by a Webkit developer. r=pagameba (Closes #1463)

in reply to: ↑ 4   Changed 5 years ago by sypasche

Replying to crschmidt:

sypasche: You'll need to add a full email address to get CCs. Sorry.

Hmm, I still received the replies in this ticket, so maybe username also work?

Can you define "fixed"? Webkit is now *accurate*: it still returns false for our current test.

I thought they reverted their change to the previous behavior on their trunk. But I'm apparently wrong, sorry for the confusion.

  Changed 5 years ago by crschmidt

Perhaps you're on the OpenLayers-trac mailing list? We don't have any way to know your username, so I'm pretty sure you didn't get email as a result of being on the CC :)

And yeah, they're still working on getting Filter support done: until then, Feature#SVG will return false, as I understand it.

Note: See TracTickets for help on using tickets.