The beforefeaturemodified event should be triggered before vertices get rendered

[tschaub]

In order to let listeners decide what to do before modification begins, the beforefeaturemodified event should get triggered before vertices get rendered. In addition, we should respect the return. As with other listeners, you should be able to return false to stop execution.

[tschaub]

trigger before action

[crschmidt]

Looks like this is okay to review? Change back if otherwise.

[elemoine]

this patch is wrong because this.feature isn't properly set when beforefeaturemodified is triggered. proper patch to come...

[elemoine]

with patch-1427-r7159-A0.diff applied, all unit tests pass on FF2, please review

[crschmidt]

Can we cook up a quick test for this? I can try if no one else cares.

[elemoine]

See patch-1427-r7546-A1.diff. Except, Layer/MultiMap.html, all unit tests pass on FF2 and FF3.

[tschaub]

In order to avoid having the feature selected at all, I added a beforefeatureselected event. The modify feature control listens to this and triggers beforefeaturemodified. If the listener returns false, the feature is not selected or modified.

[tschaub]

feature select and modify events

[elemoine]

This is looking good. Please commit.

[ahocevar]

Yes, this is really looking good. If tests pass, please go ahead and commit.

[tschaub]

(In [7616]) Adding a beforefeatureselected event to the vector layer events. If a listener returns false, the feature is not selected. The modify feature control now listens for beforefeatureselected and triggers beforefeaturemodified. If a listener returns false, feature modification never begins. r=elemione,ahocevar (closes #1427)