Ticket #1406 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

support reprojecting wfs request coordinates

Reported by: crschmidt Owned by: tschaub
Priority: minor Milestone: 2.6 Release
Component: Layer.WFS Version: 2.5
Keywords: Cc:
State: Complete

Description

Currently, WFS will try to reproject data it receives if the projection differs from the map projection... but it doesn't actually reproject the bounding box it's querying with, so this will never actually work.

Attachments

projected.patch Download (1.0 KB) - added by crschmidt 5 years ago.
projected_wfs.patch Download (3.1 KB) - added by crschmidt 5 years ago.
wfs_reprojection.patch Download (6.3 KB) - added by crschmidt 5 years ago.
wfs_reprojection.2.patch Download (5.4 KB) - added by tschaub 5 years ago.
wfs reprojected

Change History

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

The WFS layer did not properly reproject its request bounds, despite the GML reader being set up with reprojection parameters. The same was true of the WFS commit, which would not reproject. Fix both of these issues, and add FeatureServer as a datasource in the spherical-mercator example, allowing users to see how to set reprojection parameters on their layers to take advantage of automatic reprojection.

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

This functionality should have gone in with r5828, but didn't. Since that was before our 2.6 feature freeze, and this completes that feature, I'd like to put this into 2.6 if possible. (yeah, yeah, I know, feature creep)

Changed 5 years ago by crschmidt

  • state set to Review

I've just gotten confirmation from another user who has applied this patch that it works for him with spherical mercator layers as well (woot)

Changed 5 years ago by tschaub

  • state changed from Review to Needs More Work

Can you bump this in to a new example? I think it deserves it's own. Also, #1407 is related to (but not a blocker for) this.

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

  • state changed from Needs More Work to Review

Done.

Changed 5 years ago by tschaub

wfs reprojected

Changed 5 years ago by tschaub

  • state changed from Review to Commit

Thanks man. Cool example. I should have been clearer above, but my request for kicking the wfs stuff in to a new example was about leaving the spherical mercator example proxy free. I think a lot of people use that example (locally) and a lot of those people would probably be confused by the alerts.

My patch doesn't touch the spherical mercator example or proxy.cgi. The same stuff is available on port 80 there.

I've also added another bit to the example. We're still weak on style examples and I think the more the better. Plus, styleMaps rule.

If you don't like, please commit yours (maybe I'll just tweak examples later). If you agree, please commit mine. Thanks for this nice change.

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [6422]) Improve WFS reprojection:

  • Transform bbox back to layer projection
  • Transform commits back to layer projection

r=tschaub, (Closes #1406)

Note: See TracTickets for help on using tickets.