Ticket #1403 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Map move events are screwy

Reported by: euzuro Owned by:
Priority: blocker Milestone: 2.6 Release
Component: Map Version: 2.5
Keywords: Cc:
State: Complete

Description

In examples/lite.html's init() function, register the following two events so we can track the "movestart" and "moveend" events:

	        map.events.register("moveend", null, function() {
	            console.log("end");
	        });
	        map.events.register("movestart", null, function() {
	            console.log("start");
	        });

Now open lite.html in firefox and open the firebug console.

click and drag the map: notice that start and end both fire at the *end* of the drag

now click on one of the arrows in the panzoombar. start fires at beginning of pan, end at the end of it. beautiful.

now click and drag the map again: we get an end fired at the beginning of the drag, then the start and end as before at the end.

Attachments

stop_playing.patch Download (507 bytes) - added by crschmidt 5 years ago.
bring_back_dragging.patch Download (1.0 KB) - added by crschmidt 5 years ago.

Change History

Changed 5 years ago by crschmidt

Tim actually fixed at least part of this: r5674

I broke it accidentally: r6099

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

Attached patch solves the double-moveend: Specifically, we need to tell panTween we're not playing anymore after calling 'done', not just when 'stop' is called -- stop is more well termed 'cancel', which is not called regularly.

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

Bring back dragging, in a slightly different way so that we can actually fix this bug with one stone

Changed 5 years ago by euzuro

  • state set to Commit

brilliant.

all tests pass ie6, ff. please commit.

thank you, infinitely. great work

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed
Note: See TracTickets for help on using tickets.