Ticket #1357 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

Z-indexing/Y-ordering Patch

Reported by: tcoulter Owned by: euzuro
Priority: critical Milestone: 2.7 Release
Component: Layer.Vector Version: 2.5
Keywords: Cc:
State: Complete

Description

Attached is a patch for z-indexing/y-ordering for external graphics.

For an example of how to use z-indexing, see here:

Notice the "graphicZIndex" attribute attached to a feature's style. For this example, there's also a backgroundGraphicZIndex attribute; this is not included in this patch, and is instead an application specific variable.

To set a vector layer to use y-ordering in addition to z-indexing, pass the option {ordering: "y"} to the Vector layer. Example here:

Attachments

ordering.diff Download (16.3 KB) - added by tcoulter 5 years ago.
ordering-updated.patch Download (16.7 KB) - added by tcoulter 5 years ago.
Updated ordering patch that includes support for background graphics.
orderingforreview.patch Download (26.5 KB) - added by tcoulter 5 years ago.
Ordering patch slated for review.
reviewwithexample.patch Download (34.9 KB) - added by tcoulter 5 years ago.
Now with example! :)
ordering.patch Download (41.2 KB) - added by euzuro 5 years ago.
some stylistic updates and testing updates... still not finished but getting there!
ordering.2.patch Download (32.2 KB) - added by tcoulter 5 years ago.
Updated ordering patch with background graphic/shadow example.
ordering.3.patch Download (46.8 KB) - added by tcoulter 5 years ago.
Oops. Forgot to add new files to svn.
marker_shadow.png Download (374 bytes) - added by tcoulter 5 years ago.
The shadow image for marker shadown.
ordering.4.patch Download (47.8 KB) - added by tcoulter 5 years ago.
Fixed erasing of background nodes.

Change History

Changed 5 years ago by tcoulter

Changed 5 years ago by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release

Changed 5 years ago by tcoulter

Updated ordering patch that includes support for background graphics.

Changed 5 years ago by tcoulter

Just added an updated patch for the ordering stuff that includes support for background graphics. Originally, background graphics -- such as shadows -- were the motivation for writing the ordering code. The two are very coupled, so I've lumped them into one patch.

Changed 5 years ago by euzuro

  • priority changed from minor to critical

Changed 5 years ago by euzuro

  • owner changed from euzuro to tcoulter

Changed 5 years ago by tcoulter

Attaching a new patch which I'll be slating for review. This patch includes everything in the ordering-updated.patch as well as fixes for tests that ordering-updated.patch broke. The tests were slightly rewritten to reduce complexity and code duplication.

Changed 5 years ago by tcoulter

Ordering patch slated for review.

Changed 5 years ago by tcoulter

  • owner changed from tcoulter to euzero

Changed 5 years ago by tcoulter

  • owner changed from euzero to euzuro

Changed 5 years ago by tcoulter

Alright, new patch. This time, there's an example (examples/ordering.html), as well as changed the way y-ordering is specified on the layer (you don't use "z", and "y" anymore; you just say yOrdering: true).

Changed 5 years ago by tcoulter

Now with example! :)

Changed 5 years ago by euzuro

some stylistic updates and testing updates... still not finished but getting there!

Changed 5 years ago by tcoulter

Updated ordering patch with background graphic/shadow example.

Changed 5 years ago by tcoulter

Oops. Forgot to add new files to svn.

Changed 5 years ago by tcoulter

The shadow image for marker shadown.

Changed 5 years ago by tcoulter

Fixed erasing of background nodes.

Changed 5 years ago by euzuro

  • keywords review removed
  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [7652]) ordering <exclamation point/>. you can now gracefully z-order your vectors... and you can even 'yOrder' them and add background images, making for a nice 3dish look. be sure to check out the two new example html's: marker-shadow.html and ordering.html. Big thanks to tcoulter (funkyc) for a prolonged effort with this patch. It has come a long way and now what a beautiful finish. (Closes #1357)

Changed 5 years ago by euzuro

  • component changed from general to Layer.Vector
Note: See TracTickets for help on using tickets.