Tolerance and cancelling for the drag control

[sbenthall]

A useful feature for the DragFeature control would be a way to set a minimum amount of pixel-distance or time necessary for a drag to "count." We've gotten a lot of cases of accidentally drags, and this would provide a way for correcting for that.

[sbenthall]

redrawing patch for Panel.js

[sbenthall]

redrawing patch for Panel.js

[sbenthall]

I don't know what I've been doing with these patches. neither is relevant. Sorry

[sbenthall]

patch to DragFeature.js

[sbenthall]

The patch to DragFeature.js is actually relevant to this ticket.

I think that as written, the patch may be dependent on the solution to #1326 (patch already provided) in line 303, but this could be easily changed if that ticket/patch is rejected. (If, on the other hand, that ticket and patch are accepted into trunk, then the code of this class could be tightened up in a couple other places by using that Feature.Vector.move() method)

[tcoulter]

As far as I know, we don't use the code in the above patch above anymore, and we're not likely to support it in the future (we'd be happy to answer questions, however). If you don't find anything interesting in the patch above, feel free to ignore it.

[tcoulter]

Addendum: I'm referring specifically the the DragFeature.js patch, and not the patches regarding Panel.js.

[sbenthall]

i should find someboyd to review this

[sbenthall]

The current patch depends on #1357 (y-ordering) and #1126 (feature specific moving)

[sbenthall]

I'm not sure why upFeature was commented out in this patch. Need to look into it.

[crschmidt]

sbenthall: Pushing this to 'needs more work' for now, when you upload a new patch, please feel free to push it back onto my plate and I'll look at it.

[sbenthall]

Whoops. Doesn't depend on #1126. It depends on #1326, which is apparently closed.

[euzuro]

lack of activity

[crschmidt]

Not touched since 2.7, moving forward.

[arno]

updated patch

[arno]

Hi, is that feature still wanted. If case it is, I've uploaded an updated patch.

I've removed dragOffset because it seemed to work fine without it. I also noticed two small bugs in previous patch doneDragging method:

if (passesTimeTolerance passesPixelTolerance){

which I replaced with

if(passesTimeTolerance && passesPixelTolerance){

and also

this.feature.geometry.move(res * (this.startPixel.x - pixel.x),

res * (pixel.y - this.startPixel.y));

draws feature in wrong position in case the mouse went out of the map. So, I replaced it with

this.feature.geometry.move(res * (this.startPixel.x - this.lastPixel.x),

res * (this.lastPixel.y - this.startPixel.y));

I've also updated tests/Control/DragFeature.html On an unrelated note, I noticed some tests of the suite fail with opera because the same is used over and over in the different functions of a tests. So, while I was working on the testsuite, I also called map.destroy() at the end of each function because I felt it could prevent problems in the future.