Ticket #1303 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

set fallThrough property on the map to true?

Reported by: crschmidt Owned by:
Priority: minor Milestone: 2.6 Release
Component: general Version: 2.5
Keywords: Cc:
State: Complete

Description

The 'fallThrough' property on the map is set to 'false' by default. However, this means that we can't get 'title' style popups on controls (using the built in browser behavior) without changing it to true manually at map creation time.

I'm not sure that we actually need this to be 'true': i think we picked up a default from prototype somewhere along the way, and then never evaluated it. (The functionality was, for the record, added by ticket #457, which was resolved back in March, r2863).

I've not yet found a situation where having the fallThrough property set to true is a problem within OpenLayers, and I can't envision a situation where it would be a problem outside of OpenLayers.

I'd like to propose that we change the 'fallThrough' property on the map to 'true' by default for 2.6. This will allow easier use of the functionality which is being added by #822.

Looking back, I see that I added this code. I'm not sure if I need the approval of anyone else on this one, but it would be really great to get some support.

Attachments

fallthrough.patch Download (1.4 KB) - added by crschmidt 5 years ago.

Change History

Changed 5 years ago by tschaub

I think this is a good idea. Thanks for taking it on.

Changed 5 years ago by elemoine

When I had to make tooltips on controls work it took me a while to figure out I had to set fallThrough to true. If setting to true isn't a problem with the rest of OpenLayers, I'm also +1 on setting it to true by default.

Changed 5 years ago by crschmidt

Changed 5 years ago by crschmidt

  • state changed from Needs Discussion to Review

So, the attached patch changes the default, and we fail only one test: that test seems to be an *explicit* test of whether the mousedown event falls through the map, and I can't see any reason that changing that behavior will hurt us in general.

I've added a note to Release/2.6/Notes about th changing behavior, and the attached patch corrects the test: this change means that if we regress to 2.5 behavior, we will get a hard failure in the tests.

Please review.

Changed 5 years ago by elemoine

  • state changed from Review to Commit

Looks good to me. I applied your patch and every example I played with worked as expected. Please commit.

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [5907]) Set the fallThrough property to 'true' by default. This seems to have no adverse affect on the examples, is documented in the 2.6 release notes, and will allow for easier display of built-in browser tooltips for controls. r=elemoine (Closes #1303)

Note: See TracTickets for help on using tickets.