Pointtrack example does not work

[rdewit]

The following patch makes it work (rss.loadRSS() added) and has a changed location for the proxy to make it work in the examples directory.

[ahocevar]

This bug in the point-track-markers.html example was introduced by r5828, which changed the loading behavior of the GeoRSS layer.

The proposed patch is not a solution, because it uses the non-API method loadRSS to load the RSS data.

The questions now are:

• Is it valid to use a GeoRSS layer to load features that will be used by a different layer and are modified afterwards to only be displayed for specific criteria? This is what the example currently does. It is some kind of a hack. Maybe it would be better to replace this example with that one:  http://dev.openlayers.org/sandbox/ahocevar/pointtrack/examples/point-track.html, which does not use a RSS layer at all.
• Should r5828 be considered as an API break of Layer.GeoRSS?
• Should Layer.GeoRSS.loadRSS be made an API method?

For myself, I would prefer to exchange the example with the other one from the sandbox. I would not consider r5828 as an API break. I rather think that the point-track-markes.html example is kind of hackish. Also, I would not make loadRSS an API method.

What do others think?

[ahocevar]

Replying to ahocevar:

For myself, I would prefer to exchange the example with the other one from the sandbox. I would not consider r5828 as an API break. I rather think that the point-track-markes.html example is kind of hackish. Also, I would not make loadRSS an API method.

Rethinking: r5828 probably is an API break. See #1269 for further discussion.

[crschmidt]

Discussion on #1269 moved to #1273, since that's where the work was actually done: #1269 should have been marked as a dupe.

[ahocevar]

Alternative patch that does not use non-API functions and makes the whole example less hackish by calling layer.removeMarker() instead of setting marker.lonlat to null.

[crschmidt]

That looks fine -- and just so you know, example changes don't need review. Feel free to commit it.

[ahocevar]

(In [5835]) "Pointtrack example does not work". r=crschmidt (closes #1287)

[rdewit]

Hi Andreas, thanks for fixing this. To make the example work out of the box for external URLs, the URL to the proxy must be changed as well. I'll add a patch for this one now.

Just a suggestion: maybe have the map zoom to the extent of the features after loading. This will make it easier to find them (if none of them have a title/description for example).

[ahocevar]

Replying to rdewit:

Hi Andreas, thanks for fixing this. To make the example work out of the box for external URLs, the URL to the proxy must be changed as well. I'll add a patch for this one now.

Oh, this one must have slipped out. I could swear that I had added it...

Just a suggestion: maybe have the map zoom to the extent of the features after loading. This will make it easier to find them (if none of them have a title/description for example).

I do not want to overdo the example, so people looking at the source can see how the whole thing works without being distracted too much. I already have the filtering of "Untitled" features in it, so I'll better leave that one out.

[ahocevar]

(In [5836]) To make the example work out of the box for external URLs, the URL to the proxy must be changed. (closes #1287)