Ticket #1272 (closed feature: fixed)

Opened 5 years ago

Last modified 5 years ago

GPX Format class

Reported by: crschmidt Owned by: crschmidt
Priority: critical Milestone: 2.7 Release
Component: Format Version: 2.5
Keywords: Cc:
State: Complete

Description

GPX Format class allows for parsing of GPX-formatted files into linear features.

Attachments

GPXformat.patch Download (7.5 KB) - added by edgemaster 5 years ago.
GPX format based on crschmidt's original workings, tests included
t1272r7446.Format.GPX.patch Download (10.7 KB) - added by edgemaster 5 years ago.
most recent version of the GPX format class

Change History

  Changed 5 years ago by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release

Changed 5 years ago by edgemaster

GPX format based on crschmidt's original workings, tests included

  Changed 5 years ago by edgemaster

  • owner changed from crschmidt to edgemaster
  • status changed from new to assigned
  • state set to Review

Can this be reviewed please?

Format class originally by crschmidt, modified by me, tests by me.

  Changed 5 years ago by jpulles

In GPX.js the following lines

 50  for (var j = 0; j < segs.length; j++) {
 51    var track = this.extractSegment(segs[i], "trkpt");

should be changed because of the incorrect usage of i in segs[i]:

 50  for (var j = 0; j < segs.length; j++) {
 51    var track = this.extractSegment(segs[j], "trkpt");

Regards, John.

  Changed 5 years ago by edgemaster

  • state changed from Review to Needs More Work

Thanks for that, John, I'll fix up the patch and add 'attribute' extraction to the format also.

follow-up: ↓ 6   Changed 5 years ago by jpulles

There is also an error when the features need to be reprojected. Waypoints are stored as points, not as features with a geometry property that has a transform function.

in reply to: ↑ 5   Changed 5 years ago by edgemaster

Replying to jpulles:

There is also an error when the features need to be reprojected. Waypoints are stored as points, not as features with a geometry property that has a transform function.

This was fixed in r7058, the patch included with this ticket has never had this issue.

Changed 5 years ago by edgemaster

most recent version of the GPX format class

  Changed 5 years ago by edgemaster

  • state changed from Needs More Work to Review

Extraction of attributes is now supported, specific types of features can be selected for extraction also.

Bug noted by John is also fixed.

This patch has been sitting around for about a week, waiting to be added.

GPX test passes in ff2, untested in other browsers.

  Changed 5 years ago by euzuro

  • owner changed from edgemaster to crschmidt
  • status changed from assigned to new

  Changed 5 years ago by euzuro

  • priority changed from minor to critical

  Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed
Note: See TracTickets for help on using tickets.