_getScriptLocation cannot handle query string

[openlayers]

When adding a javascript file using the drupal drupal_add_js function, the src parameter may get a query string to prevent caching. The _getScriptLocation function cannot handle this, because it assumes that the scriptName is at the end of the string. In case of a query string, it should use the position of the ? as the end. A patch is attached.

For example:

<script type="text/javascript" src="/drupal/sites/all/modules/mapclient/OpenLayers-2.5/lib/OpenLayers.js?f"></script>

This would make the OpenLayers code more robust, and would facilitate integration with a CMS like Drupal.

[ahocevar]

John, nice catch. I am in favour of this patch. One small remark: If clauses in OpenLayers should never be used without curly braces (line 48/49).

It would be great to have a test for this, but I know that there is no test file for OpenLayers.js yet. I created #1267 to track this.

[openlayers]

Updated the patch per ahocevar's comment and changed milestone to reflect the one that the bug I created was set to.

[ahocevar]

same as the above patch, but applies to the OpenLayers directory root.

[ahocevar]

Patch looks good. I will commit as soon as someone reviews #1267 and tells me that the test over there is valid.

[ahocevar]

(In [5921]) "_getScriptLocation cannot handle query string". Patch originally by john.pulles@…, improved by beau@…. Thanks! r=crschmidt,me (closes #1263)