Ticket #1246 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

click handler fails if pixelTolerance is set but mousedown is stopped

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.6 Release
Component: Handler.Click Version: 2.5
Keywords: Cc:
State: Complete

Description

If the click handler is active with listeners registered on an events object that is not getting mousedown (if an element above is stopping them), clicking while pixelTolerance is set raises exceptions.

Attachments

downstopped.patch Download (1.1 KB) - added by tschaub 5 years ago.
stop passesTolerance from failing when mousedown is stopped

Change History

Changed 5 years ago by tschaub

stop passesTolerance from failing when mousedown is stopped

Changed 5 years ago by tschaub

  • state set to Review

Tests still pass, example works, and the improved overview map also works.

Changed 5 years ago by crschmidt

  • state changed from Review to Commit

Reproduced, this fixes it. Thanks, go ahead to commit.

Changed 5 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [5698]) The pixelTolerance check on the click handler only works if mousedown events get to the handler. This keeps the handler from failing in cases where mousedown is stopped and pixelTolerance is set. r=crschmidt (closes #1246)

Changed 5 years ago by tschaub

  • component changed from Handler to Handler.Click
Note: See TracTickets for help on using tickets.