Ticket #1230 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

virtual vertices aren't correctly cleaned up after feature modification

Reported by: elemoine Owned by: tschaub
Priority: major Milestone: 2.6 Release
Component: Control.ModifyFeature Version: SVN
Keywords: Cc:
State: Complete

Description

To reproduce the problem, go to < http://www.openlayers.org/dev/examples/modify-feature.html>, then

  • draw a polygon
  • select it for modification
  • drag a virtual vertex
  • unselect the polygon
  • zoom out

A vertex of the polygon is rendered on the vector layer.

Attachments

vertices.patch Download (3.8 KB) - added by tschaub 5 years ago.
better vertex management

Change History

Changed 5 years ago by crschmidt

I can't reproduce this in FF2 on Mac...

Changed 5 years ago by crschmidt

I was wrong -- I forgot to zoom in/out to see this.

Changed 5 years ago by tschaub

better vertex management

Changed 5 years ago by tschaub

  • owner changed from elemoine to tschaub
  • status changed from new to assigned
  • state set to Review
  • type changed from feature to bug

Virtual vertex needs to either get removed from the layer. This can be done directly, or it can be shifted to the vertex array for removal there. I like the second because this is more literally what we are doing - converting a virtual vertex into a regular vertex.

In addition, I've removed the redundant vertices from linear rings. We were adding duplicate vertices with no effect. No need for the extra call to the renderer.

Tests pass in FF. Please review.

Changed 5 years ago by crschmidt

  • state changed from Review to Commit

Agreed on both changes.

Changed 5 years ago by tschaub

  • status changed from assigned to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [5623]) Proper handling of virtual vertices so we don't leave them on the layer. r=crschmidt (closes #1230)

Note: See TracTickets for help on using tickets.