feature handler calls over and out for every mousemove

[tschaub]

This was an oversight on my part. The "over" and "out" callbacks should only be called on mouseover and mouseout of an eligible feature. The "click" callback should be called for every click on an eligible feature. I'm uncertain how the "clickout" callback should behave (only on the first clickout or every click outside a feature).

[tschaub]

limit callback calling

[tschaub]

Ok, tests pass with this. And, the manual acceptance pass looks good: http://openlayers.org/dev/tests/manual/feature-handler.html (one over/out per mouseover/mouseout). The clickout behavior remains the same (one clickout per click). Uncertain if this needs to be addressed. I think the code is getting a bit thorny, but the behavior is correct (as far as I could tell). Thanks for the review.

[elemoine]

definition of the inNew variable placed elsewhere

[elemoine]

Tim, the attached patch just changes where the inNew variable is defined.

If you're ok with that and tests pass please commit.

Next step is #1221.

[tschaub]

(In [5555]) Making feature handler call over and out callbacks just once per mouseover and mouseout (of a feature). r=elemoine (closes #1226)

[tschaub]

This broke the modify feature control. To see the problem,

1. open modify-feature.html
2. draw a polygon
3. modify feature with rotation
4. rotate the handle and then click the feature to unselect

[tschaub]

Ok, this change just exposed the problem with the modify feature control. This is addressed in #1235.